mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: in release notes script, do not assume electron dirname (#24927)

Browse source
This commit is contained in:
Charles Kerr 2020-08-10 18:56:54 -05:00 • committed by GitHub
parent 29a7b8f805
commit 7e84d3a2c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
script/release/notes/notes.js
View file

@ -11,7 +11,7 @@ const octokit = new Octokit({
auth: process.env.ELECTRON_GITHUB_TOKEN auth: process.env.ELECTRON_GITHUB_TOKEN
}); });
const { SRC_DIR } = require('../../lib/utils'); const { ELECTRON_DIR } = require('../../lib/utils');
const MAX_FAIL_COUNT = 3; const MAX_FAIL_COUNT = 3;
const CHECK_INTERVAL = 5000; const CHECK_INTERVAL = 5000;
@ -387,13 +387,12 @@ const getNotes = async (fromRef, toRef, newVersion) => {
} }
const pool = new Pool(); const pool = new Pool();
const electronDir = path.resolve(SRC_DIR, 'electron'); const toBranch = await getBranchNameOfRef(toRef, ELECTRON_DIR);
const toBranch = await getBranchNameOfRef(toRef, electronDir);
console.log(`Generating release notes between ${fromRef} and ${toRef} for version ${newVersion} in branch ${toBranch}`); console.log(`Generating release notes between ${fromRef} and ${toRef} for version ${newVersion} in branch ${toBranch}`);
// get the electron/electron commits // get the electron/electron commits
const electron = { owner: 'electron', repo: 'electron', dir: electronDir }; const electron = { owner: 'electron', repo: 'electron', dir: ELECTRON_DIR };
await addRepoToPool(pool, electron, fromRef, toRef); await addRepoToPool(pool, electron, fromRef, toRef);
// remove any old commits // remove any old commits