From 7e4c0b304bafddf81430c00f877682c8ab0fb65a Mon Sep 17 00:00:00 2001 From: Aleksei Kuzmin Date: Fri, 11 May 2018 14:41:58 +0300 Subject: [PATCH] Enable a few tests --- spec/api-web-contents-spec.js | 8 ++------ spec/webview-spec.js | 3 +-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/spec/api-web-contents-spec.js b/spec/api-web-contents-spec.js index 81b456ef528d..1cb169e769fa 100644 --- a/spec/api-web-contents-spec.js +++ b/spec/api-web-contents-spec.js @@ -70,9 +70,7 @@ describe('webContents module', () => { specWebContents.openDevTools() }) - // TODO(alexeykuzmin): Crashes the app. - // FIx the crash and enable the test. - xit('does not crash when called on a detached dev tools window', (done) => { + it('does not crash when called on a detached dev tools window', (done) => { const specWebContents = w.webContents specWebContents.once('devtools-opened', () => { @@ -311,9 +309,7 @@ describe('webContents module', () => { }) }) - // TODO(alexeykuzmin): Crashes the app. - // FIx the crash and enable the test. - xit('supports inspecting an element in the devtools', (done) => { + it('supports inspecting an element in the devtools', (done) => { w.loadURL('about:blank') w.webContents.once('devtools-opened', () => { done() diff --git a/spec/webview-spec.js b/spec/webview-spec.js index e41c7147b5b4..028e94ce9e9c 100644 --- a/spec/webview-spec.js +++ b/spec/webview-spec.js @@ -1495,8 +1495,7 @@ describe(' tag', function () { }) }) - // TODO(alexeykuzmin): Enable the tests. - xdescribe('disableguestresize attribute', () => { + describe('disableguestresize attribute', () => { it('does not have attribute by default', () => { loadWebView(webview) assert(!webview.hasAttribute('disableguestresize'))