From 7df51eef3ce7c874aca12cb1e1eab660b9e5d84e Mon Sep 17 00:00:00 2001 From: Alexey Kuzmin Date: Mon, 8 Oct 2018 23:56:15 +0200 Subject: [PATCH] ci: fix breakpad symbols generation on CircleCI for PRs from forks (#15026) E.g. https://circleci.com/gh/electron/electron/78458 --- .circleci/config.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 2b8ff759dc6..6ae6e15b969 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -290,14 +290,16 @@ step-mksnapshot-store: &step-mksnapshot-store step-generate-breakpad-symbols: &step-generate-breakpad-symbols run: name: Generate breakpad symbols + environment: + # TODO(alexeykuzmin): Explicitly pass an out folder path to the scripts. + ELECTRON_OUT_DIR: Default command: | cd src + # Build needed dump_syms executable ninja -C out/Default third_party/breakpad:dump_syms - electron/script/dump-symbols.py -d "$PWD/out/Default/electron.breakpad.syms" - # TODO(alexeykuzmin): Explicitly pass an out folder path to the "zip-symbols.py" script. - export ELECTRON_OUT_DIR=Default + electron/script/dump-symbols.py -d "$PWD/out/Default/electron.breakpad.syms" electron/script/zip-symbols.py step-maybe-native-mksnapshot-gn-gen: &step-maybe-native-mksnapshot-gn-gen