mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Let Chromium manage document.visibilityState and document.hidden

Browse source 
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.

Note that `webview` remains unchanged and is still affected by the issues
listed below.

User facing changes:

- The `document` visibility properties and `visibilitychange` event are
  now also updated/fired in response to occlusion changes on macOS. In
  other words, `document.visibilityState` will now be `hidden` on macOS
  if the window is occluded by another window.

- Previously, `visibilitychange` was also fired by *both* Electron and
  Chromium in some cases (e.g. when hiding the window). Now it is only
  fired by Chromium so you no longer get duplicate events.

- The visiblity state of `BrowserWindow`s created with `{ show: false }`
  is now initially `visible` until the window is shown and hidden.

- The visibility state of `BrowserWindow`s with `backgroundThrottling`
  disabled is now permanently `visible`.

This should also fix #6860 (but not for `webview`).
This commit is contained in:
Birunthan Mohanathas 2017-05-22 21:10:10 +03:00 • committed by Kevin Sawicki
parent d40a7569cc
commit 7d2226e05e
11 changed files with 175 additions and 90 deletions
Download patch file Download diff file Expand all files Collapse all files

23
atom/browser/web_contents_preferences.cc
View file

@ -186,24 +186,21 @@ void WebContentsPreferences::AppendExtraCommandLineSwitches(
command_line->AppendSwitchASCII(::switches::kDisableBlinkFeatures,
disable_blink_features);
// The initial visibility state.
NativeWindow* window = NativeWindow::FromWebContents(web_contents);
// Use embedder window for webviews
if (guest_instance_id && !window) {
if (guest_instance_id) {
// Webview `document.visibilityState` tracks window visibility so we need
// to let it know if the window happens to be hidden right now.
auto manager = WebViewManager::GetWebViewManager(web_contents);
if (manager) {
auto embedder = manager->GetEmbedder(guest_instance_id);
if (embedder)
window = NativeWindow::FromWebContents(embedder);
if (embedder) {
auto window = NativeWindow::FromWebContents(embedder);
const bool visible = window->IsVisible() && !window->IsMinimized();
if (!visible) {
command_line->AppendSwitch(switches::kHiddenPage);
}
}
}
}
if (window) {
bool visible = window->IsVisible() && !window->IsMinimized();
if (!visible) // Default state is visible.
command_line->AppendSwitch(switches::kHiddenPage);
}
}
bool WebContentsPreferences::IsPreferenceEnabled(