mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

spec: re-enable app.getAppMetric API (#13962)

Browse source
This commit is contained in:
Shelley Vohr 2018-08-09 11:35:29 -07:00 • committed by Charles Kerr
parent 271d582aac
commit 7c7543cb39
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
spec/api-app-spec.js
View file

@ -796,8 +796,7 @@ describe('app module', () => {
}) })
}) })
// TODO(marshallofsound): [Ch66] Failed on Windows x64 + ia32 on CI, passes locally describe('getAppMetrics() API', () => {
xdescribe('getAppMetrics() API', () => {
it('returns memory and cpu stats of all running electron processes', () => { it('returns memory and cpu stats of all running electron processes', () => {
const appMetrics = app.getAppMetrics() const appMetrics = app.getAppMetrics()
expect(appMetrics).to.be.an('array').and.have.lengthOf.at.least(1, 'App memory info object is not > 0') expect(appMetrics).to.be.an('array').and.have.lengthOf.at.least(1, 'App memory info object is not > 0')
@ -805,8 +804,13 @@ describe('app module', () => {
const types = [] const types = []
for (const {memory, pid, type, cpu} of appMetrics) { for (const {memory, pid, type, cpu} of appMetrics) {
expect(memory.workingSetSize).to.be.above(0, 'working set size is not > 0') expect(memory.workingSetSize).to.be.above(0, 'working set size is not > 0')
expect(memory.privateBytes).to.be.above(0, 'private bytes is not > 0')
expect(memory.sharedBytes).to.be.above(0, 'shared bytes is not > 0') // windows causes failures here due to CI server configuration
if (process.platform !== 'win32') {
expect(memory.privateBytes).to.be.above(0, 'private bytes is not > 0')
expect(memory.sharedBytes).to.be.above(0, 'shared bytes is not > 0')
}
expect(pid).to.be.above(0, 'pid is not > 0') expect(pid).to.be.above(0, 'pid is not > 0')
expect(type).to.be.a('string').that.is.not.empty() expect(type).to.be.a('string').that.is.not.empty()