mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: resolve crash loading file based serviceworkers (#20132)

Browse source
This commit is contained in:
John Kleinschmidt 2019-09-05 21:01:22 -04:00 committed by Cheng Zhao
parent 20e3c519dd
commit 7be1905023
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/net/proxying_url_loader_factory.cc
View file

@ -695,7 +695,7 @@ void ProxyingURLLoaderFactory::CreateLoaderAndStart(
// Intercept file:// protocol to support asar archives. // Intercept file:// protocol to support asar archives.
if (request.url.SchemeIsFile()) { if (request.url.SchemeIsFile()) {
asar::CreateAsarURLLoader(request, std::move(loader), std::move(client), asar::CreateAsarURLLoader(request, std::move(loader), std::move(client),
nullptr); new net::HttpResponseHeaders(""));
return; return;
} }

3
spec/chromium-spec.js
View file

@ -194,8 +194,7 @@ describe('chromium feature', () => {
}) })
}) })
// FIXME(robo/nornagon): re-enable these once service workers work describe('navigator.serviceWorker', () => {
describe.skip('navigator.serviceWorker', () => {
it('should register for file scheme', (done) => { it('should register for file scheme', (done) => {
w = new BrowserWindow({ w = new BrowserWindow({
show: false, show: false,