mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: add TRACE calls for heavy ctx bridge methods (#23501)

Browse source
This commit is contained in:
Samuel Attard 2020-05-11 14:24:43 -07:00 • committed by GitHub
parent 34da3bc500
commit 7bba36a095
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
shell/renderer/api/electron_api_context_bridge.cc
View file

@ -149,6 +149,7 @@ v8::MaybeLocal<v8::Value> PassValueToOtherContext(
context_bridge::ObjectCache* object_cache, context_bridge::ObjectCache* object_cache,
bool support_dynamic_properties, bool support_dynamic_properties,
int recursion_depth) { int recursion_depth) {
TRACE_EVENT0("electron", "ContextBridge::PassValueToOtherContext");
if (recursion_depth >= kMaxRecursion) { if (recursion_depth >= kMaxRecursion) {
v8::Context::Scope source_scope(source_context); v8::Context::Scope source_scope(source_context);
source_context->GetIsolate()->ThrowException(v8::Exception::TypeError( source_context->GetIsolate()->ThrowException(v8::Exception::TypeError(
@ -338,6 +339,7 @@ v8::Local<v8::Value> ProxyFunctionWrapper(
size_t func_id, size_t func_id,
bool support_dynamic_properties, bool support_dynamic_properties,
gin_helper::Arguments* args) { gin_helper::Arguments* args) {
TRACE_EVENT0("electron", "ContextBridge::ProxyFunctionWrapper");
// Context the proxy function was called from // Context the proxy function was called from
v8::Local<v8::Context> calling_context = args->isolate()->GetCurrentContext(); v8::Local<v8::Context> calling_context = args->isolate()->GetCurrentContext();
// Context the function was created in // Context the function was created in
@ -506,6 +508,7 @@ gin_helper::Dictionary DebugGC(gin_helper::Dictionary empty) {
void ExposeAPIInMainWorld(const std::string& key, void ExposeAPIInMainWorld(const std::string& key,
v8::Local<v8::Object> api_object, v8::Local<v8::Object> api_object,
gin_helper::Arguments* args) { gin_helper::Arguments* args) {
TRACE_EVENT1("electron", "ContextBridge::ExposeAPIInMainWorld", "key", key);
auto* render_frame = GetRenderFrame(api_object); auto* render_frame = GetRenderFrame(api_object);
CHECK(render_frame); CHECK(render_frame);
context_bridge::RenderFrameFunctionStore* store = context_bridge::RenderFrameFunctionStore* store =