mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Remove did-get-response-details and did-get-redirect-request events

Browse source 
https://chromium-review.googlesource.com/c/chromium/src/+/805008
https://chromium-review.googlesource.com/c/chromium/src/+/786320
This commit is contained in:
deepak1556 2018-04-11 23:21:37 +05:30 • committed by Samuel Attard
parent 3da6450b0c
commit 7b47d69efe
9 changed files with 0 additions and 148 deletions
Download patch file Download diff file Expand all files Collapse all files

26
spec/api-browser-window-spec.js
View file

@ -157,8 +157,6 @@ describe('BrowserWindow module', () => {
it('should not crash when invoked synchronously inside navigation observer', (done) => {
const events = [
{ name: 'did-start-loading', url: `${server.url}/200` },
{ name: '-did-get-redirect-request', url: `${server.url}/301` },
{ name: '-did-get-response-details', url: `${server.url}/200` },
{ name: 'dom-ready', url: `${server.url}/200` },
{ name: 'page-title-updated', url: `${server.url}/title` },
{ name: 'did-stop-loading', url: `${server.url}/200` },
@ -223,30 +221,6 @@ describe('BrowserWindow module', () => {
w.on('ready-to-show', () => { done() })
w.loadURL('about:blank')
})
// TODO(nitsakh): Deprecated
it('should emit did-get-response-details(deprecated) event', (done) => {
// expected {fileName: resourceType} pairs
const expectedResources = {
'did-get-response-details.html': 'mainFrame',
'logo.png': 'image'
}
let responses = 0
w.webContents.on('-did-get-response-details', (event, status, newUrl, oldUrl, responseCode, method, referrer, headers, resourceType) => {
responses += 1
const fileName = newUrl.slice(newUrl.lastIndexOf('/') + 1)
const expectedType = expectedResources[fileName]
assert(!!expectedType, `Unexpected response details for ${newUrl}`)
assert(typeof status === 'boolean', 'status should be boolean')
assert.equal(responseCode, 200)
assert.equal(method, 'GET')
assert(typeof referrer === 'string', 'referrer should be string')
assert(!!headers, 'headers should be present')
assert(typeof headers === 'object', 'headers should be object')
assert.equal(resourceType, expectedType, 'Incorrect resourceType')
if (responses === Object.keys(expectedResources).length) done()
})
w.loadURL(`file://${path.join(fixtures, 'pages', 'did-get-response-details.html')}`)
})
it('should emit did-fail-load event for files that do not exist', (done) => {
w.webContents.on('did-fail-load', (event, code, desc, url, isMainFrame) => {
assert.equal(code, -6)