From 7ae8538847bf1a8ccb3d53b2fe118a5fd1b35a80 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 31 Oct 2019 14:08:27 -0700 Subject: [PATCH] build: enable sccache on windows (#20790) * build: enable sccache on windows * chore: temporarily disable the docs only check * build: fix escaping in sccache path on windows * Update appveyor.yml * Update appveyor.yml * Use sccache settings from CI * Use Azure enabled sccache for Windows --- appveyor.yml | 3 ++- script/external-binaries.json | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 26e29919b8bd..168202b451f6 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -79,7 +79,7 @@ build_script: - gclient sync --with_branch_heads --with_tags --reset - cd src - ps: $env:BUILD_CONFIG_PATH="//electron/build/args/%GN_CONFIG%.gn" - - gn gen out/Default "--args=import(\"%BUILD_CONFIG_PATH%\") %GN_EXTRA_ARGS%" + - gn gen out/Default "--args=import(\"%BUILD_CONFIG_PATH%\") %GN_EXTRA_ARGS% cc_wrapper=\"%SCCACHE_PATH%\"" - gn check out/Default //electron:electron_lib - gn check out/Default //electron:electron_app - gn check out/Default //electron:manifests @@ -94,6 +94,7 @@ build_script: - ninja -C out/Default electron:hunspell_dictionaries_zip - ninja -C out/Default electron:electron_chromedriver_zip - ninja -C out/Default third_party/electron_node:headers + - cmd /C %SCCACHE_PATH% --show-stats - appveyor PushArtifact out/Default/dist.zip - appveyor PushArtifact out/Default/shell_browser_ui_unittests.exe - appveyor PushArtifact out/Default/chromedriver.zip diff --git a/script/external-binaries.json b/script/external-binaries.json index f1bdc4d071f2..1ff47895074c 100644 --- a/script/external-binaries.json +++ b/script/external-binaries.json @@ -1,6 +1,6 @@ { "baseUrl": "https://github.com/electron/electron-frameworks/releases/download", - "version": "v1.4.0", + "version": "v1.4.1", "binaries": [ { "url": "Mantle.zip",