From 7a04a77ed07e24efbfb3f9216e9c8863aaeeb53d Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Thu, 12 Sep 2024 20:13:27 +0200 Subject: [PATCH] refactor: avoid minor code repetition in native_image.cc (#43704) chore: delegate handle creation in NativeImage::Resize() chore: delegate handle creation in NativeImage::Crop() chore: delegate handle creation in NativeImage::CreateEmpty() Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/common/api/electron_api_native_image.cc | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/shell/common/api/electron_api_native_image.cc b/shell/common/api/electron_api_native_image.cc index cd8b8643a5d8..de9efadaea48 100644 --- a/shell/common/api/electron_api_native_image.cc +++ b/shell/common/api/electron_api_native_image.cc @@ -374,18 +374,15 @@ gin::Handle NativeImage::Resize(gin::Arguments* args, else if (quality && *quality == "better") method = skia::ImageOperations::ResizeMethod::RESIZE_BETTER; - gfx::ImageSkia resized = gfx::ImageSkiaOperations::CreateResizedImage( - image_.AsImageSkia(), method, size); - return gin::CreateHandle( - args->isolate(), new NativeImage(args->isolate(), gfx::Image(resized))); + return Create(args->isolate(), + gfx::Image{gfx::ImageSkiaOperations::CreateResizedImage( + image_.AsImageSkia(), method, size)}); } gin::Handle NativeImage::Crop(v8::Isolate* isolate, const gfx::Rect& rect) { - gfx::ImageSkia cropped = - gfx::ImageSkiaOperations::ExtractSubset(image_.AsImageSkia(), rect); - return gin::CreateHandle(isolate, - new NativeImage(isolate, gfx::Image(cropped))); + return Create(isolate, gfx::Image{gfx::ImageSkiaOperations::ExtractSubset( + image_.AsImageSkia(), rect)}); } void NativeImage::AddRepresentation(const gin_helper::Dictionary& options) { @@ -437,7 +434,7 @@ bool NativeImage::IsTemplateImage() { // static gin::Handle NativeImage::CreateEmpty(v8::Isolate* isolate) { - return gin::CreateHandle(isolate, new NativeImage(isolate, gfx::Image())); + return Create(isolate, gfx::Image{}); } // static