mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: app.getAppPath() returning default-app path for files or directories without package.json (#18763)

Browse source
This commit is contained in:
Milan Burda 2019-06-19 23:34:22 +02:00 • committed by Alexey Kuzmin
parent 7201845894
commit 79f0c444fd
4 changed files with 40 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

22
spec-main/api-app-spec.ts
View file

@ -645,6 +645,28 @@ describe('app module', () => {
})
})
describe('getAppPath', () => {
it('works for directories with package.json', async () => {
const { appPath } = await runTestApp('app-path')
expect(appPath).to.equal(path.resolve(fixturesPath, 'api/app-path'))
})
it('works for directories with index.js', async () => {
const { appPath } = await runTestApp('app-path/lib')
expect(appPath).to.equal(path.resolve(fixturesPath, 'api/app-path/lib'))
})
it('works for files without extension', async () => {
const { appPath } = await runTestApp('app-path/lib/index')
expect(appPath).to.equal(path.resolve(fixturesPath, 'api/app-path/lib'))
})
it('works for files', async () => {
const { appPath } = await runTestApp('app-path/lib/index.js')
expect(appPath).to.equal(path.resolve(fixturesPath, 'api/app-path/lib'))
})
})
describe('getPath(name)', () => {
it('returns paths that exist', () => {
const paths = [