chore: use std::make_unique/base::MakeRefCounted when possible (#29510)
This commit is contained in:
parent
a4decffe9a
commit
79cb5144ae
38 changed files with 106 additions and 101 deletions
|
@ -220,9 +220,9 @@ v8::MaybeLocal<v8::Value> PassValueToOtherContext(
|
|||
// Make the promise a shared_ptr so that when the original promise is
|
||||
// freed the proxy promise is correctly freed as well instead of being
|
||||
// left dangling
|
||||
std::shared_ptr<gin_helper::Promise<v8::Local<v8::Value>>> proxied_promise(
|
||||
new gin_helper::Promise<v8::Local<v8::Value>>(
|
||||
destination_context->GetIsolate()));
|
||||
auto proxied_promise =
|
||||
std::make_shared<gin_helper::Promise<v8::Local<v8::Value>>>(
|
||||
destination_context->GetIsolate());
|
||||
v8::Local<v8::Promise> proxied_promise_handle =
|
||||
proxied_promise->GetHandle();
|
||||
|
||||
|
|
|
@ -35,7 +35,8 @@ bool IsDevToolsExtension(content::RenderFrame* render_frame) {
|
|||
ElectronRendererClient::ElectronRendererClient()
|
||||
: node_bindings_(
|
||||
NodeBindings::Create(NodeBindings::BrowserEnvironment::kRenderer)),
|
||||
electron_bindings_(new ElectronBindings(node_bindings_->uv_loop())) {}
|
||||
electron_bindings_(
|
||||
std::make_unique<ElectronBindings>(node_bindings_->uv_loop())) {}
|
||||
|
||||
ElectronRendererClient::~ElectronRendererClient() = default;
|
||||
|
||||
|
|
|
@ -31,8 +31,7 @@ void ElectronExtensionsDispatcherDelegate::RegisterNativeHandlers(
|
|||
extensions::ScriptContext* context) {
|
||||
module_system->RegisterNativeHandler(
|
||||
"lazy_background_page",
|
||||
std::unique_ptr<NativeHandler>(
|
||||
new extensions::LazyBackgroundPageNativeHandler(context)));
|
||||
std::make_unique<extensions::LazyBackgroundPageNativeHandler>(context));
|
||||
}
|
||||
|
||||
void ElectronExtensionsDispatcherDelegate::PopulateSourceMap(
|
||||
|
|
|
@ -179,7 +179,8 @@ void RendererClientBase::RenderThreadStarted() {
|
|||
extensions_client_.reset(CreateExtensionsClient());
|
||||
extensions::ExtensionsClient::Set(extensions_client_.get());
|
||||
|
||||
extensions_renderer_client_.reset(new ElectronExtensionsRendererClient);
|
||||
extensions_renderer_client_ =
|
||||
std::make_unique<ElectronExtensionsRendererClient>();
|
||||
extensions::ExtensionsRendererClient::Set(extensions_renderer_client_.get());
|
||||
|
||||
thread->AddObserver(extensions_renderer_client_->GetDispatcher());
|
||||
|
@ -187,7 +188,7 @@ void RendererClientBase::RenderThreadStarted() {
|
|||
|
||||
#if BUILDFLAG(ENABLE_PDF_VIEWER)
|
||||
// Enables printing from Chrome PDF viewer.
|
||||
pdf_print_client_.reset(new ChromePDFPrintClient());
|
||||
pdf_print_client_ = std::make_unique<ChromePDFPrintClient>();
|
||||
pdf::PepperPDFHost::SetPrintClient(pdf_print_client_.get());
|
||||
#endif
|
||||
|
||||
|
|
|
@ -30,7 +30,8 @@ WebWorkerObserver* WebWorkerObserver::GetCurrent() {
|
|||
WebWorkerObserver::WebWorkerObserver()
|
||||
: node_bindings_(
|
||||
NodeBindings::Create(NodeBindings::BrowserEnvironment::kWorker)),
|
||||
electron_bindings_(new ElectronBindings(node_bindings_->uv_loop())) {
|
||||
electron_bindings_(
|
||||
std::make_unique<ElectronBindings>(node_bindings_->uv_loop())) {
|
||||
lazy_tls.Pointer()->Set(this);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue