mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: return early on promise rejection (#29279)

Browse source
This commit is contained in:
David Sanders 2021-06-03 21:21:02 -07:00 • committed by GitHub
parent 8e1176cbc0
commit 79ae8b427c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
shell/browser/api/electron_api_cookies.cc
View file

@ -290,6 +290,7 @@ v8::Local<v8::Promise> Cookies::Set(v8::Isolate* isolate,
const std::string* url_string = details.FindStringKey("url"); const std::string* url_string = details.FindStringKey("url");
if (!url_string) { if (!url_string) {
promise.RejectWithErrorMessage("Missing required option 'url'"); promise.RejectWithErrorMessage("Missing required option 'url'");
return handle;
} }
const std::string* name = details.FindStringKey("name"); const std::string* name = details.FindStringKey("name");
const std::string* value = details.FindStringKey("value"); const std::string* value = details.FindStringKey("value");