mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

net: change mime type deduction in Change URLRequestAsarJob (#12319)

Browse source
This commit is contained in:
Robo 2018-03-16 16:48:26 +09:00 committed by Charles Kerr
parent e93c587b8e
commit 792837bd71
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
atom/browser/net/asar/url_request_asar_job.cc
View file

@ -241,10 +241,21 @@ void URLRequestAsarJob::FetchMetaInfo(const base::FilePath& file_path,
meta_info->is_directory = file_info.is_directory; meta_info->is_directory = file_info.is_directory;
} }
} }
// On Windows GetMimeTypeFromFile() goes to the registry. Thus it should be
// done in WorkerPool. // We use GetWellKnownMimeTypeFromExtension() to ensure that configurations
meta_info->mime_type_result = // that may have been set by other programs on a user's machine don't affect
net::GetMimeTypeFromFile(file_path, &meta_info->mime_type); // the mime type returned (in particular, JS should always be
// (application/javascript). See https://crbug.com/797712. Using an accurate
// mime type is necessary at least for modules and sw, which enforce strict
// mime type requirements.
// TODO(deepak1556): Revert this when sw support is removed for file scheme.
base::FilePath::StringType file_extension = file_path.Extension();
if (file_extension.empty()) {
meta_info->mime_type_result = false;
} else {
meta_info->mime_type_result = net::GetWellKnownMimeTypeFromExtension(
file_extension.substr(1), &meta_info->mime_type);
}
} }
void URLRequestAsarJob::DidFetchMetaInfo(const FileMetaInfo* meta_info) { void URLRequestAsarJob::DidFetchMetaInfo(const FileMetaInfo* meta_info) {