mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: trigger about panel for about role on on win (#23687)

Browse source
This commit is contained in:
Shelley Vohr 2020-05-21 15:38:26 -07:00 • committed by GitHub
parent 5ed2512881
commit 78d74bf8b4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/api/menu-item.md
View file

@ -69,6 +69,7 @@ a `type`.
The `role` property can have following values: The `role` property can have following values:
* `undo` * `undo`
* `about` - Trigger a native about panel (custom message box on Window, which does not provide its own).
* `redo` * `redo`
* `cut` * `cut`
* `copy` * `copy`
@ -94,7 +95,6 @@ The `role` property can have following values:
The following additional roles are available on _macOS_: The following additional roles are available on _macOS_:
* `appMenu` - Whole default "App" menu (About, Services, etc.) * `appMenu` - Whole default "App" menu (About, Services, etc.)
* `about` - Map to the `orderFrontStandardAboutPanel` action.
* `hide` - Map to the `hide` action. * `hide` - Map to the `hide` action.
* `hideOthers` - Map to the `hideOtherApplications` action. * `hideOthers` - Map to the `hideOtherApplications` action.
* `unhide` - Map to the `unhideAllApplications` action. * `unhide` - Map to the `unhideAllApplications` action.

3
lib/browser/api/menu-item-roles.js
View file

@ -10,7 +10,8 @@ const roles = {
about: { about: {
get label () { get label () {
return isLinux ? 'About' : `About ${app.name}`; return isLinux ? 'About' : `About ${app.name}`;
} },
...(isWindows && { appMethod: 'showAboutPanel' })
}, },
close: { close: {
label: isMac ? 'Close Window' : 'Close', label: isMac ? 'Close Window' : 'Close',