From 77fa7ce977524de16e8d12c06eeed6c4979b80b9 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Tue, 29 Nov 2016 14:18:42 -0800 Subject: [PATCH] Run more crashReporter specs on CI --- spec/api-crash-reporter-spec.js | 9 ++++----- spec/chromium-spec.js | 6 ++---- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/spec/api-crash-reporter-spec.js b/spec/api-crash-reporter-spec.js index df4bbfa8ba29..781a5244f703 100644 --- a/spec/api-crash-reporter-spec.js +++ b/spec/api-crash-reporter-spec.js @@ -9,6 +9,8 @@ const {closeWindow} = require('./window-helpers') const {remote} = require('electron') const {app, BrowserWindow, crashReporter} = remote.require('electron') +const isCI = remote.getGlobal('isCi') + describe('crashReporter module', function () { var fixtures = path.resolve(__dirname, 'fixtures') var w = null @@ -33,12 +35,9 @@ describe('crashReporter module', function () { return } - var isCI = remote.getGlobal('isCi') - if (isCI) { - return - } - it('should send minidump when renderer crashes', function (done) { + if (isCi) return + this.timeout(120000) var called = false diff --git a/spec/chromium-spec.js b/spec/chromium-spec.js index 1a39edd296f9..ff27d0ecbe22 100644 --- a/spec/chromium-spec.js +++ b/spec/chromium-spec.js @@ -61,11 +61,9 @@ describe('chromium feature', function () { w.loadURL(url) }) - if (isCI && process.platform === 'win32') { - return - } - it('is set correctly when window is inactive', function (done) { + if (isCI && process.platform === 'win32') return done() + w = new BrowserWindow({ show: false })