mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't copy things on Dictionary::Set

Browse source
This commit is contained in:
Jeremy Apthorp 2018-04-25 15:18:27 -07:00
parent 99d9e262eb
commit 7733b87431
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
native_mate/converter.h
View file

@ -343,7 +343,7 @@ struct ToV8Traits<T, false> {
template <typename T> template <typename T>
bool TryConvertToV8(v8::Isolate* isolate, bool TryConvertToV8(v8::Isolate* isolate,
T input, const T& input,
v8::Local<v8::Value>* output) { v8::Local<v8::Value>* output) {
return ToV8Traits<T>::TryConvertToV8(isolate, input, output); return ToV8Traits<T>::TryConvertToV8(isolate, input, output);
} }

2
native_mate/dictionary.h
View file

@ -69,7 +69,7 @@ class Dictionary {
} }
template<typename T> template<typename T>
bool Set(const base::StringPiece& key, T val) { bool Set(const base::StringPiece& key, const T& val) {
v8::Local<v8::Value> v8_value; v8::Local<v8::Value> v8_value;
if (!TryConvertToV8(isolate_, val, &v8_value)) if (!TryConvertToV8(isolate_, val, &v8_value))
return false; return false;