mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: uaf in WebContents::DidStopLoading (#26702)

Browse source
This commit is contained in:
Jeremy Rose 2020-11-29 21:03:07 -08:00 committed by GitHub
parent 7cc571801c
commit 770e245de5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/api/electron_api_web_contents.cc
View file

@ -1447,12 +1447,12 @@ void WebContents::DidStartLoading() {
} }
void WebContents::DidStopLoading() { void WebContents::DidStopLoading() {
Emit("did-stop-loading");
auto* web_preferences = WebContentsPreferences::From(web_contents()); auto* web_preferences = WebContentsPreferences::From(web_contents());
if (web_preferences && if (web_preferences &&
web_preferences->IsEnabled(options::kEnablePreferredSizeMode)) web_preferences->IsEnabled(options::kEnablePreferredSizeMode))
web_contents()->GetRenderViewHost()->EnablePreferredSizeMode(); web_contents()->GetRenderViewHost()->EnablePreferredSizeMode();
Emit("did-stop-loading");
} }
bool WebContents::EmitNavigationEvent( bool WebContents::EmitNavigationEvent(