mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: upgrade to Node.js v14.9.0 (#25249)

Browse source
This commit is contained in:
Shelley Vohr 2020-09-17 16:08:57 -06:00 • committed by GitHub
parent 4d1dab849f
commit 77038b7bda
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
66 changed files with 724 additions and 1343 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/browser/api/net.ts
View file

@ -362,7 +362,7 @@ export class ClientRequest extends Writable implements Electron.ClientRequest {
delete this._urlLoaderOptions.extraHeaders[key];
}
_write (chunk: Buffer, encoding: string, callback: () => void) {
_write (chunk: Buffer, encoding: BufferEncoding, callback: () => void) {
this._firstWrite = true;
if (!this._body) {
this._body = new SlurpStream();
@ -481,6 +481,14 @@ export class ClientRequest extends Writable implements Electron.ClientRequest {
}
_die (err?: Error) {
// Node.js assumes that any stream which is ended is no longer capable of emitted events
// which is a faulty assumption for the case of an object that is acting like a stream
// (our urlRequest). If we don't emit here, this causes errors since we *do* expect
// that error events can be emitted after urlRequest.end().
if ((this as any)._writableState.destroyed && err) {
this.emit('error', err);
}
this.destroy(err);
if (this._urlLoader) {
this._urlLoader.cancel();