fix: 'page-title-updated' event forwarding + documentation (#18270)

This commit is contained in:
Milan Burda 2019-05-16 11:33:16 +02:00 committed by Alexey Kuzmin
parent 2a08bfbcc6
commit 76783e2a90
3 changed files with 15 additions and 2 deletions

View file

@ -416,9 +416,11 @@ Returns:
* `event` Event
* `title` String
* `explicitSet` Boolean
Emitted when the document changed its title, calling `event.preventDefault()`
will prevent the native window's title from changing.
`explicitSet` is false when title is synthesized from file url.
#### Event: 'close'

View file

@ -101,6 +101,17 @@ Returns:
Emitted when the document in the given frame is loaded.
#### Event: 'page-title-updated'
Returns:
* `event` Event
* `title` String
* `explicitSet` Boolean
Fired when page title is set during navigation. `explicitSet` is false when
title is synthesized from file url.
#### Event: 'page-favicon-updated'
Returns:

View file

@ -39,9 +39,9 @@ BrowserWindow.prototype._init = function () {
})
// Change window title to page title.
this.webContents.on('page-title-updated', (event, title) => {
this.webContents.on('page-title-updated', (event, title, ...args) => {
// Route the event to BrowserWindow.
this.emit('page-title-updated', event, title)
this.emit('page-title-updated', event, title, ...args)
if (!this.isDestroyed() && !event.defaultPrevented) this.setTitle(title)
})