fix: override the timers module impls to activate the uv loop (#18948)

This commit is contained in:
Samuel Attard 2019-06-24 10:18:29 -07:00 committed by GitHub
parent fb01c94511
commit 764be844ec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 57 additions and 8 deletions

View file

@ -212,6 +212,16 @@ describe('node feature', () => {
})
})
describe('setTimeout called under blink env in renderer process', () => {
it('can be scheduled in time', (done) => {
setTimeout(done, 10)
})
it('works from the timers module', (done) => {
require('timers').setTimeout(done, 10)
})
})
describe('setInterval called under Chromium event loop in browser process', () => {
it('can be scheduled in time', (done) => {
let interval = null
@ -229,6 +239,40 @@ describe('node feature', () => {
interval = remote.getGlobal('setInterval')(clear, 10)
})
})
describe('setInterval called under blink env in renderer process', () => {
it('can be scheduled in time', (done) => {
let interval = null
let clearing = false
const clear = () => {
if (interval === null || clearing) return
// interval might trigger while clearing (remote is slow sometimes)
clearing = true
clearInterval(interval)
clearing = false
interval = null
done()
}
interval = setInterval(clear, 10)
})
it('can be scheduled in time from timers module', (done) => {
let interval = null
let clearing = false
const clear = () => {
if (interval === null || clearing) return
// interval might trigger while clearing (remote is slow sometimes)
clearing = true
require('timers').clearInterval(interval)
clearing = false
interval = null
done()
}
interval = require('timers').setInterval(clear, 10)
})
})
})
describe('inspector', () => {