mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: native View wrapper crash missing when adding child view (#43698)

Browse source 
fix: native View wrapper crash missing when adding child view

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot] 2024-09-12 12:48:12 +02:00 • committed by GitHub
parent 8ca3b8f84e
commit 763d3983a1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 29 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/api-view-spec.ts
View file

@ -36,6 +36,18 @@ describe('View', () => {
expect(w.contentView.children).to.have.lengthOf(1);
});
it('can be added as a child of another View', async () => {
const w = new BaseWindow();
const v1 = new View();
const v2 = new View();
v1.addChildView(v2);
w.contentView.addChildView(v1);
expect(w.contentView.children).to.deep.equal([v1]);
expect(v1.children).to.deep.equal([v2]);
});
it('correctly reorders children', () => {
w = new BaseWindow({ show: false });
const cv = new View();