mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: compensate for title bar height when setting bounds on BrowserView (#34713)

Browse source 
fix: compensate for title bar height when setting bounds
This commit is contained in:
Shelley Vohr 2022-08-29 17:53:03 +02:00 • committed by GitHub
parent d0e220cbce
commit 75f9573e53
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 39 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spec/api-browser-view-spec.ts
View file

@ -146,7 +146,14 @@ describe('BrowserView module', () => {
});
describe('BrowserView.getBounds()', () => {
it('returns the current bounds', () => {
it('returns correct bounds on a framed window', () => {
view = new BrowserView();
const bounds = { x: 10, y: 20, width: 30, height: 40 };
view.setBounds(bounds);
expect(view.getBounds()).to.deep.equal(bounds);
});
it('returns correct bounds on a frameless window', () => {
view = new BrowserView();
const bounds = { x: 10, y: 20, width: 30, height: 40 };
view.setBounds(bounds);