mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

clean up excess code from generateGroupId

Browse source
This commit is contained in:
Shelley Vohr 2017-10-24 00:24:57 -04:00
parent f93121b226
commit 75f32afcd5
No known key found for this signature in database
GPG key ID: F13993A75599653C
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lib/browser/api/menu.js
View file

@ -188,20 +188,15 @@ Menu.buildFromTemplate = function (template) {
// Search between separators to find a radio menu item and return its group id // Search between separators to find a radio menu item and return its group id
function generateGroupId (items, pos) { function generateGroupId (items, pos) {
let i, item
if (pos > 0) { if (pos > 0) {
let asc, start for (let idx = pos - 1; idx >= 0; idx--) {
for (start = pos - 1, i = start, asc = start <= 0; asc ? i <= 0 : i >= 0; asc ? i++ : i--) { if (items[idx].type === 'radio') return items[idx].groupId
item = items[i] if (items[idx].type === 'separator') break
if (item.type === 'radio') { return item.groupId }
if (item.type === 'separator') { break }
} }
} else if (pos < items.length) { } else if (pos < items.length) {
let asc1, end for (let idx = pos; idx <= items.length - 1; idx++) {
for (i = pos, end = items.length - 1, asc1 = pos <= end; asc1 ? i <= end : i >= end; asc1 ? i++ : i--) { if (items[idx].type === 'radio') return items[idx].groupId
item = items[i] if (items[idx].type === 'separator') break
if (item.type === 'radio') { return item.groupId }
if (item.type === 'separator') { break }
} }
} }
groupIdIndex += 1 groupIdIndex += 1