mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

inspector: stop dragging platform pointer

Browse source 
296fd57324
This commit is contained in:
Aleksei Kuzmin 2018-09-04 11:15:17 +02:00
parent 11349ebf2e
commit 7589555cec
4 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/app/node_main.cc
View file

@ -65,7 +65,7 @@ int NodeMain(int argc, char* argv[]) {
// Enable support for v8 inspector. // Enable support for v8 inspector.
NodeDebugger node_debugger(env); NodeDebugger node_debugger(env);
node_debugger.Start(gin_env.platform()); node_debugger.Start();
mate::Dictionary process(gin_env.isolate(), env->process_object()); mate::Dictionary process(gin_env.isolate(), env->process_object());
#if defined(OS_WIN) #if defined(OS_WIN)

2
atom/browser/atom_browser_main_parts.cc
View file

@ -144,7 +144,7 @@ void AtomBrowserMainParts::PostEarlyInitialization() {
// Enable support for v8 inspector // Enable support for v8 inspector
node_debugger_.reset(new NodeDebugger(env)); node_debugger_.reset(new NodeDebugger(env));
node_debugger_->Start(js_env_->platform()); node_debugger_->Start();
// Add Electron extended APIs. // Add Electron extended APIs.
atom_bindings_->BindTo(js_env_->isolate(), env->process_object()); atom_bindings_->BindTo(js_env_->isolate(), env->process_object());

5
atom/browser/node_debugger.cc
View file

@ -19,7 +19,7 @@ NodeDebugger::NodeDebugger(node::Environment* env) : env_(env) {}
NodeDebugger::~NodeDebugger() {} NodeDebugger::~NodeDebugger() {}
void NodeDebugger::Start(node::MultiIsolatePlatform* platform) { void NodeDebugger::Start() {
auto* inspector = env_->inspector_agent(); auto* inspector = env_->inspector_agent();
if (inspector == nullptr) if (inspector == nullptr)
return; return;
@ -45,8 +45,7 @@ void NodeDebugger::Start(node::MultiIsolatePlatform* platform) {
process.Set("_breakFirstLine", true); process.Set("_breakFirstLine", true);
} }
inspector->Start(static_cast<node::NodePlatform*>(platform), nullptr, inspector->Start(/* path */ nullptr, options);
options);
DCHECK(env_->inspector_agent()->IsStarted()); DCHECK(env_->inspector_agent()->IsStarted());
} }

3
atom/browser/node_debugger.h
View file

@ -9,7 +9,6 @@
namespace node { namespace node {
class Environment; class Environment;
class MultiIsolatePlatform;
} // namespace node } // namespace node
namespace atom { namespace atom {
@ -20,7 +19,7 @@ class NodeDebugger {
explicit NodeDebugger(node::Environment* env); explicit NodeDebugger(node::Environment* env);
~NodeDebugger(); ~NodeDebugger();
void Start(node::MultiIsolatePlatform* platform); void Start();
private: private:
node::Environment* env_; node::Environment* env_;