mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Use const instead of var

Browse source
This commit is contained in:
Kevin Sawicki 2017-02-22 14:15:59 -08:00
parent f4717b34e9
commit 7564a9973b
1 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

16
lib/renderer/web-view/web-view.js
View file

@ -264,8 +264,7 @@ const registerBrowserPluginElement = function () {
this.style.flex = '1 1 auto' this.style.flex = '1 1 auto'
} }
proto.attributeChangedCallback = function (name, oldValue, newValue) { proto.attributeChangedCallback = function (name, oldValue, newValue) {
var internal const internal = v8Util.getHiddenValue(this, 'internal')
internal = v8Util.getHiddenValue(this, 'internal')
if (internal) { if (internal) {
internal.handleBrowserPluginAttributeMutation(name, oldValue, newValue) internal.handleBrowserPluginAttributeMutation(name, oldValue, newValue)
} }
@ -285,21 +284,19 @@ const registerBrowserPluginElement = function () {
} }
// Registers <webview> custom element. // Registers <webview> custom element.
var registerWebViewElement = function () { const registerWebViewElement = function () {
const proto = Object.create(HTMLObjectElement.prototype) const proto = Object.create(HTMLObjectElement.prototype)
proto.createdCallback = function () { proto.createdCallback = function () {
return new WebViewImpl(this) return new WebViewImpl(this)
} }
proto.attributeChangedCallback = function (name, oldValue, newValue) { proto.attributeChangedCallback = function (name, oldValue, newValue) {
var internal const internal = v8Util.getHiddenValue(this, 'internal')
internal = v8Util.getHiddenValue(this, 'internal')
if (internal) { if (internal) {
internal.handleWebviewAttributeMutation(name, oldValue, newValue) internal.handleWebviewAttributeMutation(name, oldValue, newValue)
} }
} }
proto.detachedCallback = function () { proto.detachedCallback = function () {
var internal const internal = v8Util.getHiddenValue(this, 'internal')
internal = v8Util.getHiddenValue(this, 'internal')
if (!internal) { if (!internal) {
return return
} }
@ -309,8 +306,7 @@ var registerWebViewElement = function () {
internal.reset() internal.reset()
} }
proto.attachedCallback = function () { proto.attachedCallback = function () {
var internal, instance const internal = v8Util.getHiddenValue(this, 'internal')
internal = v8Util.getHiddenValue(this, 'internal')
if (!internal) { if (!internal) {
return return
} }
@ -318,7 +314,7 @@ var registerWebViewElement = function () {
ipcRenderer.on('ELECTRON_RENDERER_WINDOW_VISIBILITY_CHANGE', internal.onVisibilityChanged) ipcRenderer.on('ELECTRON_RENDERER_WINDOW_VISIBILITY_CHANGE', internal.onVisibilityChanged)
guestViewInternal.registerEvents(internal, internal.viewInstanceId) guestViewInternal.registerEvents(internal, internal.viewInstanceId)
internal.elementAttached = true internal.elementAttached = true
instance = internal.attributes[webViewConstants.ATTRIBUTE_GUESTINSTANCE].getValue() const instance = internal.attributes[webViewConstants.ATTRIBUTE_GUESTINSTANCE].getValue()
if (instance) { if (instance) {
internal.attachGuestInstance(instance) internal.attachGuestInstance(instance)
} else { } else {