fix: make devtools extensions load correctly (#17614)

This commit is contained in:
Samuel Attard 2019-03-30 17:36:13 -07:00 committed by GitHub
parent d597a0e8b0
commit 75442b794f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 26 additions and 8 deletions

View file

@ -122,7 +122,7 @@ export function injectTo (extensionId: string, context: any) {
[targetExtensionId, connectInfo] = args
}
const { tabId, portId } = ipcRendererInternal.sendSync('CHROME_RUNTIME_CONNECT', targetExtensionId, connectInfo)
const { tabId, portId } = ipcRendererUtils.invokeSync('CHROME_RUNTIME_CONNECT', targetExtensionId, connectInfo)
return new Port(tabId, portId, extensionId, connectInfo.name)
},
@ -210,4 +210,10 @@ export function injectTo (extensionId: string, context: any) {
chrome.i18n = require('@electron/internal/renderer/extensions/i18n').setup(extensionId)
chrome.webNavigation = require('@electron/internal/renderer/extensions/web-navigation').setup()
// Electron has no concept of a browserAction but we should stub these APIs for compatibility
chrome.browserAction = {
setIcon () {},
setPopup () {}
}
}