mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: native View wrapper crash missing when adding child view (#43638)

Browse source 
fix: native View wrapper crash missing when adding child view
This commit is contained in:
Shelley Vohr 2024-09-12 10:01:05 +02:00 • committed by GitHub
parent dea6a4e5fb
commit 74b54278bf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 29 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/api-view-spec.ts
View file

@ -36,6 +36,18 @@ describe('View', () => {
expect(w.contentView.children).to.have.lengthOf(1);
});
it('can be added as a child of another View', async () => {
const w = new BaseWindow();
const v1 = new View();
const v2 = new View();
v1.addChildView(v2);
w.contentView.addChildView(v1);
expect(w.contentView.children).to.deep.equal([v1]);
expect(v1.children).to.deep.equal([v2]);
});
it('correctly reorders children', () => {
w = new BaseWindow({ show: false });
const cv = new View();