fix: destroy WebContents synchronously on shutdown (#15541)

This commit is contained in:
Cheng Zhao 2018-11-09 00:57:28 +09:00 committed by Shelley Vohr
parent 6162d9090d
commit 746beb0d8b
12 changed files with 122 additions and 13 deletions

View file

@ -1,8 +1,18 @@
'use strict'
const assert = require('assert')
const chai = require('chai')
const ChildProcess = require('child_process')
const dirtyChai = require('dirty-chai')
const path = require('path')
const { emittedOnce } = require('./events-helpers')
const { closeWindow } = require('./window-helpers')
const { webContents, TopLevelWindow, WebContentsView } = require('electron').remote
const { remote } = require('electron')
const { webContents, TopLevelWindow, WebContentsView } = remote
const { expect } = chai
chai.use(dirtyChai)
describe('WebContentsView', () => {
let w = null
@ -22,4 +32,14 @@ describe('WebContentsView', () => {
w.setContentView(new WebContentsView(web))
}, /The WebContents has already been added to a View/)
})
describe('new WebContentsView()', () => {
it('does not crash on exit', async () => {
const appPath = path.join(__dirname, 'fixtures', 'api', 'leak-exit-webcontentsview.js')
const electronPath = remote.getGlobal('process').execPath
const appProcess = ChildProcess.spawn(electronPath, [appPath])
const [code] = await emittedOnce(appProcess, 'close')
expect(code).to.equal(0)
})
})
})