feat: enhance native window.open to match the custom implementation's behavior (#19703)

Co-authored-by: Andy Locascio <andy@slack-corp.com>
2020-03-26 19:05:45 +01:00 · 2020-03-26 19:05:45 +01:00 · 74372d65ae
commit 74372d65ae
parent b1f4ac00f0
20 changed files with 350 additions and 143 deletions
--- a/shell/browser/api/electron_api_app.h
+++ b/shell/browser/api/electron_api_app.h
@ -131,7 +131,7 @@ class App : public ElectronBrowserClient::Delegate,
                       const std::string& frame_name,
                       WindowOpenDisposition disposition,
                       const blink::mojom::WindowFeatures& features,
-                       const std::vector<std::string>& additional_features,
+                       const std::string& raw_features,
                       const scoped_refptr<network::ResourceRequestBody>& body,
                       bool user_gesture,
                       bool opener_suppressed,