feat: enhance native window.open to match the custom implementation's behavior (#19703)

Co-authored-by: Andy Locascio <andy@slack-corp.com>

lib/common/parse-features-string.js

@@ -3,7 +3,7 @@
 // parses a feature string that has the format used in window.open()
 // - `features` input string
 // - `emit` function(key, value) - called for each parsed KV
-module.exports = function parseFeaturesString (features, emit) {
+function parseFeaturesString (features, emit) {
   features = `${features}`.trim();
   // split the string by ','
   features.split(/\s*,\s*/).forEach((feature) => {
@@ -18,4 +18,68 @@ module.exports = function parseFeaturesString (features, emit) {
     // emit the parsed pair
     emit(key, value);
   });
+}
+
+function convertFeaturesString (features, frameName) {
+  const options = {};
+
+  const ints = ['x', 'y', 'width', 'height', 'minWidth', 'maxWidth', 'minHeight', 'maxHeight', 'zoomFactor'];
+  const webPreferences = ['zoomFactor', 'nodeIntegration', 'enableRemoteModule', 'preload', 'javascript', 'contextIsolation', 'webviewTag'];
+
+  // Used to store additional features
+  const additionalFeatures = [];
+
+  // Parse the features
+  parseFeaturesString(features, function (key, value) {
+    if (value === undefined) {
+      additionalFeatures.push(key);
+    } else {
+      // Don't allow webPreferences to be set since it must be an object
+      // that cannot be directly overridden
+      if (key === 'webPreferences') return;
+
+      if (webPreferences.includes(key)) {
+        if (options.webPreferences == null) {
+          options.webPreferences = {};
+        }
+        options.webPreferences[key] = value;
+      } else {
+        options[key] = value;
+      }
+    }
+  });
+
+  if (options.left) {
+    if (options.x == null) {
+      options.x = options.left;
+    }
+  }
+  if (options.top) {
+    if (options.y == null) {
+      options.y = options.top;
+    }
+  }
+  if (options.title == null) {
+    options.title = frameName;
+  }
+  if (options.width == null) {
+    options.width = 800;
+  }
+  if (options.height == null) {
+    options.height = 600;
+  }
+
+  for (const name of ints) {
+    if (options[name] != null) {
+      options[name] = parseInt(options[name], 10);
+    }
+  }
+
+  return {
+    options, additionalFeatures
+  };
+}
+
+module.exports = {
+  parseFeaturesString, convertFeaturesString
 };