mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Remove unused constructor of Dictionary.

Browse source
This commit is contained in:
Cheng Zhao 2014-09-09 13:32:41 +08:00
parent 980036b78a
commit 742923c73d
2 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
native_mate/dictionary.cc
View file

@ -6,9 +6,8 @@
namespace mate { namespace mate {
Dictionary::Dictionary(v8::Isolate* isolate) Dictionary::Dictionary()
: isolate_(isolate), : isolate_(NULL) {
object_(MATE_OBJECT_NEW(isolate)) {
} }
Dictionary::Dictionary(v8::Isolate* isolate, Dictionary::Dictionary(v8::Isolate* isolate,
@ -20,12 +19,6 @@ Dictionary::Dictionary(v8::Isolate* isolate,
Dictionary::~Dictionary() { Dictionary::~Dictionary() {
} }
Dictionary Dictionary::CreateEmpty(v8::Isolate* isolate) {
Dictionary dictionary(isolate);
dictionary.object_ = MATE_OBJECT_NEW(isolate);
return dictionary;
}
v8::Handle<v8::Value> Converter<Dictionary>::ToV8(v8::Isolate* isolate, v8::Handle<v8::Value> Converter<Dictionary>::ToV8(v8::Isolate* isolate,
Dictionary val) { Dictionary val) {
return val.object_; return val.object_;

4
native_mate/dictionary.h
View file

@ -24,12 +24,10 @@ namespace mate {
// //
class Dictionary { class Dictionary {
public: public:
Dictionary(v8::Isolate* isolate = v8::Isolate::GetCurrent()); Dictionary();
Dictionary(v8::Isolate* isolate, v8::Handle<v8::Object> object); Dictionary(v8::Isolate* isolate, v8::Handle<v8::Object> object);
~Dictionary(); ~Dictionary();
static Dictionary CreateEmpty(v8::Isolate* isolate);
template<typename T> template<typename T>
bool Get(const base::StringPiece& key, T* out) const { bool Get(const base::StringPiece& key, T* out) const {
v8::Handle<v8::Value> val = object_->Get(StringToV8(isolate_, key)); v8::Handle<v8::Value> val = object_->Get(StringToV8(isolate_, key));