mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: remove unnecessary std::moves in linux code (#12951)

Browse source 
The compiler was complaining that the move was preventing copy elision.
This commit is contained in:
Jeremy Apthorp 2018-05-15 14:33:47 -07:00 committed by GitHub
parent 8fa48d1c04
commit 73eb5af2cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/lib/power_observer_linux.cc
View file

@ -23,7 +23,7 @@ std::string get_executable_basename() {
if (!uv_exepath(buf, &buf_size)) { if (!uv_exepath(buf, &buf_size)) {
rv = strrchr(static_cast<const char*>(buf), '/') + 1; rv = strrchr(static_cast<const char*>(buf), '/') + 1;
} }
return std::move(rv); return rv;
} }
} // namespace } // namespace

2
atom/browser/ui/views/submenu_button.cc
View file

@ -32,7 +32,7 @@ SubmenuButton::SubmenuButton(const base::string16& title,
background_color_(background_color) { background_color_(background_color) {
#if defined(OS_LINUX) #if defined(OS_LINUX)
// Dont' use native style border. // Dont' use native style border.
SetBorder(std::move(CreateDefaultBorder())); SetBorder(CreateDefaultBorder());
#endif #endif
if (GetUnderlinePosition(title, &accelerator_, &underline_start_, if (GetUnderlinePosition(title, &accelerator_, &underline_start_,