mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

feat: automatically round numbers that are converted to points (#14604)

Browse source 
Fixes #14490
This commit is contained in:
Samuel Attard 2018-09-13 23:28:56 +10:00 • committed by Charles Kerr
parent 7d7401987a
commit 73a1a8b3f0
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
atom/common/native_mate_converters/gfx_converter.cc
View file

@ -28,10 +28,11 @@ bool Converter<gfx::Point>::FromV8(v8::Isolate* isolate,
mate::Dictionary dict; mate::Dictionary dict;
if (!ConvertFromV8(isolate, val, &dict)) if (!ConvertFromV8(isolate, val, &dict))
return false; return false;
int x, y; double x, y;
if (!dict.Get("x", &x) || !dict.Get("y", &y)) if (!dict.Get("x", &x) || !dict.Get("y", &y))
return false; return false;
*out = gfx::Point(x, y); *out = gfx::Point(static_cast<int>(std::round(x)),
static_cast<int>(std::round(y)));
return true; return true;
} }

4
docs/api/structures/point.md
View file

@ -2,3 +2,7 @@
* `x` Number * `x` Number
* `y` Number * `y` Number
**Note:** Both `x` and `y` must be whole integers, when providing a point object
as input to an Electron API we will automatically round your `x` and `y` values
to the nearest whole integer.