mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Improve deprecated message on webPreferences options

Browse source
This commit is contained in:
Kevin Sawicki 2016-03-17 13:34:30 -07:00
parent c31882749d
commit 737ffd8d7c
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/browser/api/browser-window.js
View file

@ -280,7 +280,7 @@ const checkForDeprecatedOptions = function(options) {
} }
if (webPreferenceOption) { if (webPreferenceOption) {
try { try {
deprecate.log(`Setting ${webPreferenceOption} on options is deprecated. Set it on options.webPreferences instead.`); deprecate.log(`options.${webPreferenceOption} is deprecated. Use options.webPreferences.${webPreferenceOption} instead.`);
} catch (error) { } catch (error) {
// Return error message so it can be rethrown via C++ // Return error message so it can be rethrown via C++
return error.message; return error.message;

2
spec/api-browser-window-spec.js
View file

@ -776,7 +776,7 @@ describe('browser-window module', function() {
it('throws a deprecation error for option keys that should be set on webPreferences', function() { it('throws a deprecation error for option keys that should be set on webPreferences', function() {
assert.throws(function () { assert.throws(function () {
new BrowserWindow({zoomFactor: 1}); new BrowserWindow({zoomFactor: 1});
}, 'Setting zoomFactor on options is deprecated. Set it on options.webPreferences instead.'); }, 'options.zoomFactor is deprecated. Use options.webPreferences.zoomFactor instead.');
}); });
}); });
}); });