mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: remove unused local variables (#44823)

Browse source 
* chore: remove unused local non-trivial variable relaunch_executable

became unused in June 2016 in 0d066de5

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: only declare program_name local variable if used

We declared it everywhere but only used it on Windows

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: remove unused local non-trivial variable path from UnregisterXWindow

it became unused in 2020 by 72a08926

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot] 2024-11-24 08:54:56 -06:00 committed by GitHub
parent 5670b17b40
commit 73243cb9c4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
shell/browser/api/electron_api_app.cc
View file

@ -1011,8 +1011,6 @@ bool App::RequestSingleInstanceLock(gin::Arguments* args) {
if (HasSingleInstanceLock()) if (HasSingleInstanceLock())
return true; return true;
std::string program_name = electron::Browser::Get()->GetName();
base::FilePath user_dir; base::FilePath user_dir;
base::PathService::Get(chrome::DIR_USER_DATA, &user_dir); base::PathService::Get(chrome::DIR_USER_DATA, &user_dir);
// The user_dir may not have been created yet. // The user_dir may not have been created yet.
@ -1023,6 +1021,7 @@ bool App::RequestSingleInstanceLock(gin::Arguments* args) {
blink::CloneableMessage additional_data_message; blink::CloneableMessage additional_data_message;
args->GetNext(&additional_data_message); args->GetNext(&additional_data_message);
#if BUILDFLAG(IS_WIN) #if BUILDFLAG(IS_WIN)
const std::string program_name = electron::Browser::Get()->GetName();
bool app_is_sandboxed = bool app_is_sandboxed =
IsSandboxEnabled(base::CommandLine::ForCurrentProcess()); IsSandboxEnabled(base::CommandLine::ForCurrentProcess());
process_singleton_ = std::make_unique<ProcessSingleton>( process_singleton_ = std::make_unique<ProcessSingleton>(

1
shell/browser/relauncher.cc
View file

@ -157,7 +157,6 @@ int RelauncherMain(const content::MainFunctionParams& main_parameters) {
// Figure out what to execute, what arguments to pass it, and whether to // Figure out what to execute, what arguments to pass it, and whether to
// start it in the background. // start it in the background.
bool in_relauncher_args = false; bool in_relauncher_args = false;
StringType relaunch_executable;
StringVector relauncher_args; StringVector relauncher_args;
StringVector launch_argv; StringVector launch_argv;
for (size_t argv_index = 2; argv_index < argv.size(); ++argv_index) { for (size_t argv_index = 2; argv_index < argv.size(); ++argv_index) {

1
shell/browser/ui/views/global_menu_bar_registrar_x11.cc
View file

@ -80,7 +80,6 @@ void GlobalMenuBarRegistrarX11::RegisterXWindow(x11::Window window) {
void GlobalMenuBarRegistrarX11::UnregisterXWindow(x11::Window window) { void GlobalMenuBarRegistrarX11::UnregisterXWindow(x11::Window window) {
DCHECK(registrar_proxy_); DCHECK(registrar_proxy_);
std::string path = electron::GlobalMenuBarX11::GetPathForWindow(window);
ANNOTATE_SCOPED_MEMORY_LEAK; // http://crbug.com/314087 ANNOTATE_SCOPED_MEMORY_LEAK; // http://crbug.com/314087
// TODO(erg): The mozilla implementation goes to a lot of callback trouble // TODO(erg): The mozilla implementation goes to a lot of callback trouble