From 72f3a22ecc7af82ac459595c00950f5863112082 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Fri, 8 Feb 2019 13:26:59 -0800 Subject: [PATCH] docs: reorder crashReporter notes to make more sense (#16825) the note about reports from child processes on Windows should be next to the code snippet. Side note: is that code even still necessary? --- docs/api/crash-reporter.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/api/crash-reporter.md b/docs/api/crash-reporter.md index dcd64a3bbd2..65208df684f 100644 --- a/docs/api/crash-reporter.md +++ b/docs/api/crash-reporter.md @@ -62,14 +62,14 @@ Therefore, to collect crash reports from them, use `process.crashReporter.start` along with an additional one called `crashesDirectory` that should point to a directory to store the crash reports temporarily. You can test this out by calling `process.crash()` to crash the child process. -**Note:** To collect crash reports from child process in Windows, you need to add this extra code as well. -This will start the process that will monitor and send the crash reports. Replace `submitURL`, `productName` -and `crashesDirectory` with appropriate values. - **Note:** If you need send additional/updated `extra` parameters after your first call `start` you can call `addExtraParameter` on macOS or call `start` again with the new/updated `extra` parameters on Linux and Windows. +**Note:** To collect crash reports from child process in Windows, you need to add this extra code as well. +This will start the process that will monitor and send the crash reports. Replace `submitURL`, `productName` +and `crashesDirectory` with appropriate values. + ```js const args = [ `--reporter-url=${submitURL}`,