fix: split out login item tests (#15135)

spec/api-app-spec.js

@@ -432,16 +432,23 @@ describe('app module', () => {
       app.setLoginItemSettings({ openAtLogin: false, path: updateExe, args: processStartArgs })
     })
 
-    it('returns the login item status of the app', done => {
+    it('sets and returns the app as a login item', done => {
       app.setLoginItemSettings({ openAtLogin: true })
-      expect(app.getLoginItemSettings()).to.deep.equal({
+      // Wait because login item settings are not applied immediately in MAS build
-        openAtLogin: true,
+      const delay = process.mas ? 150 : 0
-        openAsHidden: false,
+      setTimeout(() => {
-        wasOpenedAtLogin: false,
+        expect(app.getLoginItemSettings()).to.deep.equal({
-        wasOpenedAsHidden: false,
+          openAtLogin: true,
-        restoreState: false
+          openAsHidden: false,
-      })
+          wasOpenedAtLogin: false,
+          wasOpenedAsHidden: false,
+          restoreState: false
+        })
+        done()
+      }, delay)
+    })
 
+    it('adds a login item that loads in hidden mode', () => {
       app.setLoginItemSettings({ openAtLogin: true, openAsHidden: true })
       expect(app.getLoginItemSettings()).to.deep.equal({
         openAtLogin: true,
@@ -450,20 +457,6 @@ describe('app module', () => {
         wasOpenedAsHidden: false,
         restoreState: false
       })
-
-      app.setLoginItemSettings({})
-      // Wait because login item settings are not applied immediately in MAS build
-      const delay = process.mas ? 100 : 0
-      setTimeout(() => {
-        expect(app.getLoginItemSettings()).to.deep.equal({
-          openAtLogin: false,
-          openAsHidden: false,
-          wasOpenedAtLogin: false,
-          wasOpenedAsHidden: false,
-          restoreState: false
-        })
-        done()
-      }, delay)
     })
 
     it('correctly sets and unsets the LoginItem as hidden', function () {