From 7299dd1501aa309036ab7d6ed9b4d92ba673e02c Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 1 Apr 2025 20:53:43 -0500 Subject: [PATCH] perf: avoid redundant map lookup in UsbChooserContext::OnDeviceRemoved() (#46418) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/usb/usb_chooser_context.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shell/browser/usb/usb_chooser_context.cc b/shell/browser/usb/usb_chooser_context.cc index 3b5d26b5f729..1273b7dbd41e 100644 --- a/shell/browser/usb/usb_chooser_context.cc +++ b/shell/browser/usb/usb_chooser_context.cc @@ -302,8 +302,8 @@ void UsbChooserContext::OnDeviceRemoved( } // Update the device list. - DCHECK(devices_.contains(device_info->guid)); - devices_.erase(device_info->guid); + const size_t n_erased = devices_.erase(device_info->guid); + DCHECK_EQ(n_erased, 1U); // Notify all device observers. for (auto& observer : device_observer_list_)