mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: improve granular release cleanup (#15900)

Browse source 
* chore: improve granular release cleanup

* make releaseId optional
This commit is contained in:
Shelley Vohr 2018-11-30 09:58:09 -08:00 committed by GitHub
parent 2e91bf1e15
commit 728be219a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
script/release-artifact-cleanup.js
View file

@ -2,8 +2,11 @@
if (!process.env.CI) require('dotenv-safe').load()
require('colors')
const pass = '\u2713'.green
const fail = '\u2717'.red
const args = require('minimist')(process.argv.slice(2), {
string: ['tag']
string: ['tag', 'releaseId'],
default: { releaseId: '' }
})
const { execSync } = require('child_process')
const { GitProcess } = require('dugite')
@ -32,7 +35,7 @@ async function getCurrentBranch (gitDir) {
}
const error = GitProcess.parseError(branchDetails.stderr)
console.error(`Couldn't get current branch: `, error)
console.error(`${fail} couldn't get current branch: `, error)
process.exit(1)
}
@ -42,10 +45,10 @@ async function revertBumpCommit (tag) {
await GitProcess.exec(['revert', commitToRevert], gitDir)
const pushDetails = await GitProcess.exec(['push', 'origin', `HEAD:${branch}`, '--follow-tags'], gitDir)
if (pushDetails.exitCode === 0) {
console.log(`Successfully reverted release commit.`)
console.log(`${pass} successfully reverted release commit.`)
} else {
const error = GitProcess.parseError(pushDetails.stderr)
console.error(`Failed to push release commit: `, error)
console.error(`${fail} could not push release commit: `, error)
process.exit(1)
}
}
@ -59,8 +62,8 @@ async function deleteDraft (releaseId, targetRepo) {
})
console.log(result)
if (!result.draft) {
console.log(`Published releases cannot be deleted.`)
process.exit(1)
console.log(`${fail} published releases cannot be deleted.`)
return false
} else {
await github.repos.deleteRelease({
owner: 'electron',
@ -68,10 +71,11 @@ async function deleteDraft (releaseId, targetRepo) {
release_id: result.id
})
}
console.log(`Successfully deleted draft with id ${releaseId} from ${targetRepo}`)
console.log(`${pass} successfully deleted draft with id ${releaseId} from ${targetRepo}`)
return true
} catch (err) {
console.error(`Couldn't delete draft with id ${releaseId} from ${targetRepo}: `, err)
process.exit(1)
console.error(`${fail} couldn't delete draft with id ${releaseId} from ${targetRepo}: `, err)
return false
}
}
@ -82,29 +86,39 @@ async function deleteTag (tag, targetRepo) {
repo: targetRepo,
ref: tag
})
console.log(`Successfully deleted tag ${tag} from ${targetRepo}`)
console.log(`${pass} successfully deleted tag ${tag} from ${targetRepo}`)
} catch (err) {
console.log(`Couldn't delete tag ${tag} from ${targetRepo}: `, err)
process.exit(1)
console.log(`${fail} couldn't delete tag ${tag} from ${targetRepo}: `, err)
}
}
async function cleanReleaseArtifacts () {
const releaseId = args.releaseId
const releaseId = args.releaseId.length > 0 ? args.releaseId : null
const isNightly = args.tag.includes('nightly')
if (isNightly) {
await deleteDraft(releaseId, 'nightlies')
await deleteTag(args.tag, 'nightlies')
} else {
console.log('we are here')
await deleteDraft(releaseId, 'electron')
if (releaseId) {
if (isNightly) {
const deletedNightlyDraft = await deleteDraft(releaseId, 'nightlies')
// don't delete tag unless draft deleted successfully
if (deletedNightlyDraft) {
await Promise.all([
deleteTag(args.tag, 'electron'),
deleteTag(args.tag, 'nightlies')
])
}
} else {
const deletedElectronDraft = await deleteDraft(releaseId, 'electron')
// don't delete tag unless draft deleted successfully
if (deletedElectronDraft) {
await deleteTag(args.tag, 'electron')
}
}
}
await deleteTag(args.tag, 'electron')
// try to revert commit regardless of tag and draft deletion status
await revertBumpCommit(args.tag)
console.log('Failed release artifact cleanup complete')
console.log(`${pass} failed release artifact cleanup complete`)
}
cleanReleaseArtifacts()