Fix code styling problems

This commit is contained in:
Cheng Zhao 2016-05-05 12:26:23 +09:00
parent 3f2a25d07c
commit 7268f434b2
9 changed files with 51 additions and 36 deletions

View file

@ -250,11 +250,14 @@ void App::OnFinishLaunching() {
Emit("ready");
}
void App::OnContinueUserActivity(bool* prevent_default,
const std::string& type,
const std::map<std::string, std::string>& user_info) {
#if defined(OS_MACOSX)
void App::OnContinueUserActivity(
bool* prevent_default,
const std::string& type,
const std::map<std::string, std::string>& user_info) {
*prevent_default = Emit("continue-activity", type, user_info);
}
#endif
void App::OnLogin(LoginHandler* login_handler) {
v8::Locker locker(isolate());

View file

@ -72,9 +72,12 @@ class App : public AtomBrowserClient::Delegate,
void OnWillFinishLaunching() override;
void OnFinishLaunching() override;
void OnLogin(LoginHandler* login_handler) override;
void OnContinueUserActivity(bool* prevent_default,
const std::string& type,
const std::map<std::string, std::string>& user_info) override;
#if defined(OS_MACOSX)
void OnContinueUserActivity(
bool* prevent_default,
const std::string& type,
const std::map<std::string, std::string>& user_info) override;
#endif
// content::ContentBrowserClient:
void AllowCertificateError(

View file

@ -138,9 +138,9 @@ void Browser::Activate(bool has_visible_windows) {
}
#if defined(OS_MACOSX)
bool Browser::ContinueUserActivity(const std::string& type,
const std::map<std::string,
std::string>& user_info) {
bool Browser::ContinueUserActivity(
const std::string& type,
const std::map<std::string, std::string>& user_info) {
bool prevent_default = false;
FOR_EACH_OBSERVER(BrowserObserver,
observers_,

View file

@ -101,8 +101,9 @@ class Browser : public WindowListObserver {
std::string GetCurrentActivityType();
// Resumes an activity via hand-off.
bool ContinueUserActivity(const std::string& type,
const std::map<std::string, std::string>& user_info);
bool ContinueUserActivity(
const std::string& type,
const std::map<std::string, std::string>& user_info);
// Bounce the dock icon.
enum BounceType {

View file

@ -87,17 +87,20 @@ bool Browser::IsDefaultProtocolClient(const std::string& protocol) {
void Browser::SetAppUserModelID(const base::string16& name) {
}
void Browser::SetUserActivity(const std::string& type, const std::map<std::string, std::string>& user_info) {
void Browser::SetUserActivity(
const std::string& type,
const std::map<std::string, std::string>& user_info) {
NSString* type_ns = [NSString stringWithUTF8String:type.c_str()];
NSUserActivity* user_activity = [[NSUserActivity alloc] initWithActivityType:type_ns];
NSUserActivity* user_activity =
[[NSUserActivity alloc] initWithActivityType:type_ns];
base::scoped_nsobject<NSMutableDictionary> user_info_args([[NSMutableDictionary alloc] init]);
base::scoped_nsobject<NSMutableDictionary> user_info_args(
[[NSMutableDictionary alloc] init]);
for (auto const &pair : user_info) {
NSString* value_ns = [NSString stringWithUTF8String:pair.second.c_str()];
NSString* key_ns = [NSString stringWithUTF8String:pair.first.c_str()];
[user_info_args.get() setObject:value_ns
forKey:key_ns];
[user_info_args.get() setObject:value_ns forKey:key_ns];
}
user_activity.userInfo = user_info_args.get();
@ -107,7 +110,8 @@ void Browser::SetUserActivity(const std::string& type, const std::map<std::strin
}
std::string Browser::GetCurrentActivityType() {
NSUserActivity* user_activity = [[AtomApplication sharedApplication] getCurrentActivity];
NSUserActivity* user_activity =
[[AtomApplication sharedApplication] getCurrentActivity];
return base::SysNSStringToUTF8(user_activity.activityType);
}

View file

@ -8,6 +8,8 @@
#include <string>
#include <map>
#include "build/build_config.h"
namespace atom {
class LoginHandler;
@ -46,10 +48,13 @@ class BrowserObserver {
// The browser requests HTTP login.
virtual void OnLogin(LoginHandler* login_handler) {}
#if defined(OS_MACOSX)
// The browser wants to resume a user activity via handoff. (OS X only)
virtual void OnContinueUserActivity(bool* prevent_default,
const std::string& type,
const std::map<std::string, std::string>& user_info) {}
virtual void OnContinueUserActivity(
bool* prevent_default,
const std::string& type,
const std::map<std::string, std::string>& user_info) {}
#endif
protected:
virtual ~BrowserObserver() {}

View file

@ -21,7 +21,6 @@
- (void)setHandlingSendEvent:(BOOL)handlingSendEvent;
- (NSUserActivity*)getCurrentActivity;
- (void)setCurrentActivity:(NSUserActivity*)userActivity;
@end

View file

@ -59,9 +59,9 @@
return flag;
}
- (BOOL)application:(NSApplication *)sender
continueUserActivity:(NSUserActivity *)userActivity
restorationHandler:(void (^)(NSArray *restorableObjects))restorationHandler {
- (BOOL)application:(NSApplication*)sender
continueUserActivity:(NSUserActivity*)userActivity
restorationHandler:(void (^)(NSArray*restorableObjects))restorationHandler {
std::string activity_type(base::SysNSStringToUTF8(userActivity.activityType));
std::map<std::string, std::string> user_info;