test: extract RemoteControlApp to spec-helpers (#24020)

This commit is contained in:
Jeremy Rose 2020-06-09 11:42:53 -07:00 committed by GitHub
parent d08cfce6cb
commit 71e2b7151c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 82 additions and 66 deletions

View file

@ -4,6 +4,7 @@ import * as http from 'http';
import * as url from 'url';
import { AddressInfo, Socket } from 'net';
import { emittedOnce } from './events-helpers';
import { defer } from './spec-helpers';
const kOneKiloByte = 1024;
const kOneMegaByte = kOneKiloByte * kOneKiloByte;
@ -22,13 +23,6 @@ function randomString (length: number) {
return buffer.toString();
}
const cleanupTasks: (() => void)[] = [];
function cleanUp () {
cleanupTasks.forEach(t => t());
cleanupTasks.length = 0;
}
async function getResponse (urlRequest: Electron.ClientRequest) {
return new Promise<Electron.IncomingMessage>((resolve, reject) => {
urlRequest.on('error', reject);
@ -70,7 +64,7 @@ function respondNTimes (fn: http.RequestListener, n: number): Promise<string> {
});
const sockets: Socket[] = [];
server.on('connection', s => sockets.push(s));
cleanupTasks.push(() => {
defer(() => {
server.close();
sockets.forEach(s => s.destroy());
});
@ -118,7 +112,6 @@ describe('net module', () => {
beforeEach(() => {
routeFailure = false;
});
afterEach(cleanUp);
afterEach(async function () {
await session.defaultSession.clearCache();
if (routeFailure && this.test) {