From 71d3a86d325ebb4666f44136b9187edaf26030d0 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 11 Feb 2025 11:37:11 +0100 Subject: [PATCH] fix: fix mksnapshot gen/v8 path (#45546) * fix: fix mksnapshot gen/v8 path Co-authored-by: Keeley Hammond * build: use 7z compression Co-authored-by: Keeley Hammond * build: unzip mksnapshot on Windows and update zip Co-authored-by: John Kleinschmidt * chore: escape backslashes Co-authored-by: David Sanders * chore: try another attempt Co-authored-by: David Sanders * chore: remove rmdir for now Co-authored-by: David Sanders --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond Co-authored-by: John Kleinschmidt Co-authored-by: David Sanders --- .github/actions/build-electron/action.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/actions/build-electron/action.yml b/.github/actions/build-electron/action.yml index 176883272f7d..58a416e01f40 100644 --- a/.github/actions/build-electron/action.yml +++ b/.github/actions/build-electron/action.yml @@ -108,7 +108,9 @@ runs: if [ "${{ inputs.target-platform }}" = "win" ]; then cd out/Default powershell Compress-Archive -update mksnapshot_args mksnapshot.zip - powershell Compress-Archive -update gen/v8/embedded.S mksnapshot.zip + powershell mkdir mktmp\\gen\\v8 + powershell Copy-Item gen\\v8\\embedded.S mktmp\\gen\\v8 + powershell Compress-Archive -update -Path mktmp\\gen mksnapshot.zip else (cd out/Default; zip mksnapshot.zip mksnapshot_args gen/v8/embedded.S) fi