Merge pull request #2619 from etiktin/ignore_native_modules_in_debug_tests_windows

Skip native modules in debug tests on Windows

.gitignore

@@ -17,3 +17,4 @@ node_modules/
 *.pyc
 debug.log
 npm-debug.log
+atom/common/chrome_version.h

docs/development/build-instructions-windows.md

@@ -82,6 +82,15 @@ Test functionality using:
 python script\test.py
 ```
 
+Tests that include native modules (e.g. `runas`) can't be executed with the
+debug build (see #2558 for details), but they will work with the release build.
+
+To run the tests with the release build use:
+
+```powershell
+python script\test.py -R
+```
+
 ## Troubleshooting
 
 ### Command xxxx not found

spec/modules-spec.coffee

@@ -7,6 +7,10 @@ describe 'third-party module', ->
   fixtures = path.join __dirname, 'fixtures'
   temp.track()
 
+  # If the test is executed with the debug build on Windows, we will skip it
+  # because native modules don't work with the debug build (see issue #2558).
+  if process.platform isnt 'win32' or
+      process.execPath.toLowerCase().indexOf('\\out\\d\\') is -1
     describe 'runas', ->
       it 'can be required in renderer', ->
         require 'runas'

spec/webview-spec.coffee

@@ -48,6 +48,10 @@ describe '<webview> tag', ->
       webview.src = "file://#{fixtures}/pages/d.html"
       document.body.appendChild webview
 
+    # If the test is executed with the debug build on Windows, we will skip it
+    # because native modules don't work with the debug build (see issue #2558).
+    if process.platform isnt 'win32' or
+        process.execPath.toLowerCase().indexOf('\\out\\d\\') is -1
       it 'loads native modules when navigation happens', (done) ->
         listener = (e) ->
           webview.removeEventListener 'did-finish-load', listener