mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: patch dump_syms to not hard fail on dylib resolve error (#15056)

Browse source
This commit is contained in:
Samuel Attard 2018-10-11 00:34:50 +11:00 committed by GitHub
parent 5667c16767
commit 7159080ec5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
patches/common/chromium/.patches.yaml
View file

@ -484,3 +484,10 @@ patches:
Pass idle quit closure for main message loop, so that pending tasks are Pass idle quit closure for main message loop, so that pending tasks are
run before shutdown. This is required to cleanup WebContents asynchronously run before shutdown. This is required to cleanup WebContents asynchronously
in atom::CommonWebContentsDelegate::ResetManageWebContents. in atom::CommonWebContentsDelegate::ResetManageWebContents.
-
author: Samuel Attard <samuel.r.attard@gmail.com>
file: dump_syms.patch
description: |
dylib currently fails to resolve Squirrel.framework on OSX, we need to fix
this but it is not a blocker for releasing Electron. This patch removes
the hard fail on dylib resolve failure from dump_syms

13
patches/common/chromium/dump_syms.patch Normal file
View file

@ -0,0 +1,13 @@
diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py
index 2032f1991ada..58646a10591a 100755
--- a/components/crash/content/tools/generate_breakpad_symbols.py
+++ b/components/crash/content/tools/generate_breakpad_symbols.py
@@ -159,7 +159,7 @@ def GetSharedLibraryDependenciesMac(binary, exe_path):
'ERROR: failed to resolve %s, exe_path %s, loader_path %s, '
'rpaths %s' % (m.group(1), exe_path, loader_path,
', '.join(rpaths)))
- sys.exit(1)
+ # sys.exit(1)
return deps