mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

build: improve error output in release.js (#38658)

Browse source
This commit is contained in:
David Sanders 2023-06-08 07:49:12 +08:00 • committed by GitHub
parent 08ab45535d
commit 714402b08e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
script/release/release.js
View file

@ -77,7 +77,7 @@ async function validateReleaseAssets (release, validatingRelease) {
} else { } else {
await verifyShasumsForRemoteFiles(downloadUrls) await verifyShasumsForRemoteFiles(downloadUrls)
.catch(err => { .catch(err => {
console.log(`${fail} error verifyingShasums`, err); console.error(`${fail} error verifyingShasums`, err);
}); });
} }
const azRemoteFiles = azRemoteFilesForVersion(release.tag_name); const azRemoteFiles = azRemoteFilesForVersion(release.tag_name);
@ -90,7 +90,7 @@ function check (condition, statement, exitIfFail = false) {
console.log(`${pass} ${statement}`); console.log(`${pass} ${statement}`);
} else { } else {
failureCount++; failureCount++;
console.log(`${fail} ${statement}`); console.error(`${fail} ${statement}`);
if (exitIfFail) process.exit(1); if (exitIfFail) process.exit(1);
} }
} }
@ -212,7 +212,7 @@ function runScript (scriptName, scriptArgs, cwd) {
try { try {
return execSync(scriptCommand, scriptOptions); return execSync(scriptCommand, scriptOptions);
} catch (err) { } catch (err) {
console.log(`${fail} Error running ${scriptName}`, err); console.error(`${fail} Error running ${scriptName}`, err);
process.exit(1); process.exit(1);
} }
} }
@ -266,7 +266,8 @@ async function createReleaseShasums (release) {
repo: targetRepo, repo: targetRepo,
asset_id: existingAssets[0].id asset_id: existingAssets[0].id
}).catch(err => { }).catch(err => {
console.log(`${fail} Error deleting ${fileName} on GitHub:`, err); console.error(`${fail} Error deleting ${fileName} on GitHub:`, err);
process.exit(1);
}); });
} }
console.log(`Creating and uploading the release ${fileName}.`); console.log(`Creating and uploading the release ${fileName}.`);
@ -292,7 +293,7 @@ async function uploadShasumFile (filePath, fileName, releaseId) {
data: fs.createReadStream(filePath), data: fs.createReadStream(filePath),
name: fileName name: fileName
}).catch(err => { }).catch(err => {
console.log(`${fail} Error uploading ${filePath} to GitHub:`, err); console.error(`${fail} Error uploading ${filePath} to GitHub:`, err);
process.exit(1); process.exit(1);
}); });
} }
@ -301,13 +302,13 @@ function saveShaSumFile (checksums, fileName) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
temp.open(fileName, (err, info) => { temp.open(fileName, (err, info) => {
if (err) { if (err) {
console.log(`${fail} Could not create ${fileName} file`); console.error(`${fail} Could not create ${fileName} file`);
process.exit(1); process.exit(1);
} else { } else {
fs.writeFileSync(info.fd, checksums); fs.writeFileSync(info.fd, checksums);
fs.close(info.fd, (err) => { fs.close(info.fd, (err) => {
if (err) { if (err) {
console.log(`${fail} Could close ${fileName} file`); console.error(`${fail} Could close ${fileName} file`);
process.exit(1); process.exit(1);
} }
resolve(info.path); resolve(info.path);
@ -336,7 +337,7 @@ async function publishRelease (release) {
draft: false, draft: false,
make_latest: makeLatest ? 'true' : 'false' make_latest: makeLatest ? 'true' : 'false'
}).catch(err => { }).catch(err => {
console.log(`${fail} Error publishing release:`, err); console.error(`${fail} Error publishing release:`, err);
process.exit(1); process.exit(1);
}); });
} }
@ -406,7 +407,7 @@ async function verifyDraftGitHubReleaseAssets (release) {
return { url: response.headers.location, file: asset.name }; return { url: response.headers.location, file: asset.name };
})).catch(err => { })).catch(err => {
console.log(`${fail} Error downloading files from GitHub`, err); console.error(`${fail} Error downloading files from GitHub`, err);
process.exit(1); process.exit(1);
}); });