mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: add will-redirect (#13866)

Browse source 
* feat: add will-redirect to allow people to prevent 30X redirects

* spec: add tests for the will-redirect event

* refactor: implement will-redirect using NavigationThrottle instead of PostTask

This avoids a potential race condition and immediately cancels the
navigation

* docs: add docs for did-redirect-navigation

* refactor: move AtomNavigationThrottle out of net folder

* refactor: update header guard for atom_navigation_throttle.h

* refactor: fix chromium style errors in the GN build

* refactor: update throttle impl to NOTREACHED and std::make_unqique
This commit is contained in:
Samuel Attard 2018-09-16 01:42:43 +10:00 • committed by GitHub
parent 6ad8583a8b
commit 7065093869
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 222 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

27
atom/browser/atom_navigation_throttle.h Normal file
View file

@ -0,0 +1,27 @@
// Copyright (c) 2018 GitHub, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ATOM_BROWSER_ATOM_NAVIGATION_THROTTLE_H_
#define ATOM_BROWSER_ATOM_NAVIGATION_THROTTLE_H_
#include "content/public/browser/navigation_throttle.h"
namespace atom {
class AtomNavigationThrottle : public content::NavigationThrottle {
public:
explicit AtomNavigationThrottle(content::NavigationHandle* handle);
~AtomNavigationThrottle() override;
AtomNavigationThrottle::ThrottleCheckResult WillRedirectRequest() override;
const char* GetNameForLogging() override;
private:
DISALLOW_COPY_AND_ASSIGN(AtomNavigationThrottle);
};
} // namespace atom
#endif // ATOM_BROWSER_ATOM_NAVIGATION_THROTTLE_H_