Exposing process.env status (#12166)

lib/sandboxed_renderer/init.js

@@ -44,6 +44,7 @@ preloadProcess.getSystemMemoryInfo = () => binding.getSystemMemoryInfo()
 preloadProcess.argv = binding.getArgv()
 process.platform = preloadProcess.platform = electron.remote.process.platform
 process.execPath = preloadProcess.execPath = electron.remote.process.execPath
+process.env = preloadProcess.env = electron.remote.process.env
 process.on('exit', () => preloadProcess.emit('exit'))
 
 // This is the `require` function that will be visible to the preload script

spec/api-browser-window-spec.js

@@ -1539,6 +1539,23 @@ describe('BrowserWindow module', () => {
           done()
         })
       })
+
+      it('validate process.env access in sandbox renderer', (done) => {
+        ipcMain.once('answer', function (event, test) {
+          assert.equal(test, 'foo')
+          done()
+        })
+        remote.process.env.sandboxmain = 'foo'
+        w.destroy()
+        w = new BrowserWindow({
+          show: false,
+          webPreferences: {
+            sandbox: true,
+            preload: preload
+          }
+        })
+        w.loadURL('file://' + path.join(fixtures, 'api', 'preload.html'))
+      })
     })
 
     describe('nativeWindowOpen option', () => {

spec/fixtures/module/preload-sandbox.js

@@ -7,6 +7,9 @@
   if (location.protocol === 'file:') {
     window.test = 'preload'
     window.process = process
+    if (process.env.sandboxmain) {
+      window.test = process.env.sandboxmain
+    }
   } else if (location.href !== 'about:blank') {
     addEventListener('DOMContentLoaded', () => {
       ipcRenderer.send('child-loaded', window.opener == null, document.body.innerHTML)

spec/static/main.js

@@ -38,6 +38,9 @@ process.env.ELECTRON_DISABLE_SECURITY_WARNINGS = true
 // eslint-disable-next-line
 process.stdout
 
+// Adding a variable for sandbox process.env test validation
+process.env.sandboxmain = ''
+
 // Access console to reproduce #3482.
 // eslint-disable-next-line
 console