mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: update to latest TypeScript, which has built-in WeakRef declarations (#27425)

Browse source
This commit is contained in:
Milan Burda 2021-01-22 20:25:47 +01:00 • committed by GitHub
parent fcdb7ad21a
commit 70190ec2b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
27 changed files with 70 additions and 128 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spec-main/api-menu-spec.ts
View file

@ -868,7 +868,7 @@ describe('Menu module', function () {
// Keep a weak reference to the menu.
// eslint-disable-next-line no-undef
const wr = new (globalThis as any).WeakRef(menu);
const wr = new WeakRef(menu);
await delay();
@ -881,7 +881,7 @@ describe('Menu module', function () {
// Try to receive menu from weak reference.
if (wr.deref()) {
wr.deref().closePopup();
wr.deref()!.closePopup();
} else {
throw new Error('Menu is garbage-collected while popuping');
}
@ -910,7 +910,7 @@ describe('Menu module', function () {
const appProcess = cp.spawn(process.execPath, [appPath]);
let output = '';
await new Promise((resolve) => {
await new Promise<void>((resolve) => {
appProcess.stdout.on('data', data => {
output += data;
if (data.indexOf('Window has') > -1) {