mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Use object for verification request

Browse source
This commit is contained in:
Kevin Sawicki 2017-02-07 16:35:37 -08:00
parent 5245d42d15
commit 70178adb6e
7 changed files with 52 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

21
spec/api-session-spec.js
View file

@ -557,8 +557,8 @@ describe('session module', function () {
})
it('accepts the request when the callback is called with true', function (done) {
session.defaultSession.setCertificateVerifyProc(function (hostname, certificate, error, callback) {
assert.equal(error, 'net::ERR_CERT_AUTHORITY_INVALID')
session.defaultSession.setCertificateVerifyProc(function ({hostname, certificate, verificationResult}, callback) {
assert.equal(verificationResult, 'net::ERR_CERT_AUTHORITY_INVALID')
callback(0)
})
@ -569,8 +569,21 @@ describe('session module', function () {
w.loadURL(`https://127.0.0.1:${server.address().port}`)
})
it('supports the old function signature', function (done) {
session.defaultSession.setCertificateVerifyProc(function (hostname, certificate, callback) {
assert.equal(hostname, '127.0.0.1')
callback(true)
})
w.webContents.once('did-finish-load', function () {
assert.equal(w.webContents.getTitle(), 'hello')
done()
})
w.loadURL(`https://127.0.0.1:${server.address().port}`)
})
it('rejects the request when the callback is called with false', function (done) {
session.defaultSession.setCertificateVerifyProc(function (hostname, certificate, error, callback) {
session.defaultSession.setCertificateVerifyProc(function ({hostname, certificate, verificationResult}, callback) {
assert.equal(hostname, '127.0.0.1')
assert.equal(certificate.issuerName, 'Intermediate CA')
assert.equal(certificate.subjectName, 'localhost')
@ -581,7 +594,7 @@ describe('session module', function () {
assert.equal(certificate.issuerCert.issuerCert.issuer.commonName, 'Root CA')
assert.equal(certificate.issuerCert.issuerCert.subject.commonName, 'Root CA')
assert.equal(certificate.issuerCert.issuerCert.issuerCert, undefined)
assert.equal(error, 'net::ERR_CERT_AUTHORITY_INVALID')
assert.equal(verificationResult, 'net::ERR_CERT_AUTHORITY_INVALID')
callback(-2)
})